fixed the double clicking of materalization button, and freezing problem#2831
Draft
Pawan-webdeveloper wants to merge 1 commit intoFreezingMoon:masterfrom
Draft
fixed the double clicking of materalization button, and freezing problem#2831Pawan-webdeveloper wants to merge 1 commit intoFreezingMoon:masterfrom
Pawan-webdeveloper wants to merge 1 commit intoFreezingMoon:masterfrom
Conversation
|
@Pawan-webdeveloper is attempting to deploy a commit to the FreezingMoon Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
|
@Pawan-webdeveloper I've tested this with clicks and hotkeys and it doesn't fixes the issue at all 🐻 |
Member
|
@Pawan-webdeveloper You can test this deployment here btw -> https://ancientbeast-em6aju5t5-freezingmoon.vercel.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue #2775 Godlet Printer selected but inactive [bounty: 33 XTR]
Issues:
and after the second click, because the UI sets selection directly, the grid’s active query state are now in an overwritten state, so the player ends up in a “selected ability but no effective interaction” situation.
What i fixed:
1.Added a guard flag UI.materializeInProgress in interface.ts , so a second click does nothing while a pick is already active.
2. Also added some cleanups.